Update triple and some relies version, add consumer registry timeout configuration item #1516
Conversation
|
3.0 Samples is no needs to run time.Sleep() to wait for service discovery, and the max wait time can be configured in consumer level, with api or config file. |
| @@ -50,7 +48,8 @@ type ConsumerConfig struct { | |||
|
|
|||
| References map[string]*ReferenceConfig `yaml:"references" json:"references,omitempty" property:"references"` | |||
|
|
|||
| FilterConf interface{} `yaml:"filter-conf" json:"filter-conf,omitempty" property:"filter-conf"` | |||
| FilterConf interface{} `yaml:"filter-conf" json:"filter-conf,omitempty" property:"filter-conf"` | |||
There was a problem hiding this comment.
1.下划线是不是要改横线
2.为什么要添加这个key
There was a problem hiding this comment.
- 我改成横线吧
- 用来配置客户端的 registry 超时时间
Codecov Report
@@ Coverage Diff @@
## 3.0 #1516 +/- ##
==========================================
- Coverage 41.86% 41.76% -0.10%
==========================================
Files 259 259
Lines 15109 15120 +11
==========================================
- Hits 6325 6315 -10
- Misses 8049 8062 +13
- Partials 735 743 +8
Continue to review full report at Codecov.
|
go.mod
Outdated
| @@ -11,12 +11,12 @@ require ( | |||
| github.com/apache/dubbo-go-hessian2 v1.9.3 | |||
| github.com/creasty/defaults v1.5.2 | |||
| github.com/dubbogo/go-zookeeper v1.0.3 | |||
| github.com/dubbogo/gost v1.11.17 | |||
| github.com/dubbogo/triple v1.0.6-0.20210909153707-3620c8d2d97c | |||
| github.com/dubbogo/gost v1.11.18-0.20211011142005-8a95129ef6e2 | |||
| @@ -133,12 +133,17 @@ func registerPOJO() { | |||
|
|
|||
| func (rc *RootConfig) Init() error { | |||
| registerPOJO() | |||
| if err := rc.Logger.Init(); err != nil { | |||
| if err := rc.Logger.Init(); err != nil { // init default logger | |||
There was a problem hiding this comment.
I think this is useless code.
If you init logger after configcenter , and print success info. Then if not success info of config center then init fail.
There was a problem hiding this comment.
The dependency logic is: config-center's Init procedure relies on default logger, because it would print some logs using default logger. And the user-configed logger relies on config-center's init procedure, to get the logger config from config-center and set the default logger to target logger. So the init logic is
- [Init default Logger to avoid NPE if user not configure logger] or [Init user configured logger]
- Try to load configuration from config center, to overwrite local configuration
- Reload Logger with latest configuration file. The result is also default logger or user configured logger.
And It's not useless codes. @zouyx
go.mod
Outdated
| github.com/dubbogo/gost v1.11.17 | ||
| github.com/dubbogo/triple v1.0.6-0.20210909153707-3620c8d2d97c | ||
| github.com/dubbogo/gost v1.11.18-0.20211011142005-8a95129ef6e2 | ||
| github.com/dubbogo/triple v1.0.7-0.20211012074236-faf8a9baedd6 |
No description provided.